Skip to content

hotfix: Fix setting containers_list and running without a command #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markgoddard merged 2 commits into from
Mar 19, 2024
Merged

hotfix: Fix setting containers_list and running without a command #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1564f4
hotfix: Fix setting containers_list and running without a command
markgoddard Mar 15, 2024
37b387a
hotfix: Fix failure message
markgoddard Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions etc/kayobe/ansible/hotfix-containers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@

- name: Set fact for containers list
set_fact:
containers_list: host_containers.stdout
containers_list: "{{ host_containers.stdout }}"

- name: Fail if no containers match given regex
vars:
hotfix_containers: "{{ containers_list | split('\n') | regex_search(container_hotfix_container_regex) }}"
fail:
msg: "No containers matched. Please check your regex. Containers running on host: {{ host_containers | split('\n') }}"
msg: "No containers matched. Please check your regex. Containers running on host: {{ host_containers.stdout_lines }}"
when: hotfix_containers == ""

- name: Ensure hotfix-files directory exists on the remote host
Expand Down
1 change: 1 addition & 0 deletions etc/kayobe/ansible/run-container-hotfix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@

- name: Run container_hotfix_command
command: "{{ kolla_container_engine | default('docker')}} exec {{ '-u 0' if container_hotfix_become else '' }} {{ hotfix_container }} {{ container_hotfix_command }}"
when: container_hotfix_command