Skip to content

Bump integrations/github to v6#484

Open
priteau wants to merge 1 commit intomainfrom
bump-integrations-github
Open

Bump integrations/github to v6#484
priteau wants to merge 1 commit intomainfrom
bump-integrations-github

Conversation

@priteau
Copy link
Member

@priteau priteau commented Feb 26, 2026

No description provided.

@priteau priteau self-assigned this Feb 26, 2026
@priteau priteau requested a review from a team as a code owner February 26, 2026 12:05
@gemini-code-assist
Copy link

Summary of Changes

Hello @priteau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the integrations/github Terraform provider to its latest stable version. This upgrade is crucial for maintaining compatibility, accessing new functionalities, and benefiting from performance improvements and security patches offered in newer releases.

Highlights

  • GitHub Provider Version Bump: The integrations/github Terraform provider has been updated from version 4.28.0 to 6.11.1 in terraform/github/provider.tf.
Changelog
  • terraform/github/provider.tf
    • Updated the github provider version from 4.28.0 to 6.11.1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integrations/github Terraform provider from version 4.28.0 to 6.11.1. This is a major version upgrade that introduces significant breaking changes that are not addressed in this PR. The current Terraform configuration will fail with this new provider version. I've added a critical comment on the version change, detailing the necessary changes in other files (repositories.tf, branches.tf) to make the configuration compatible with version 6.x of the provider. These changes must be implemented for the Terraform apply to succeed.

seunghun1ee
seunghun1ee previously approved these changes Feb 27, 2026
@priteau priteau force-pushed the bump-integrations-github branch 3 times, most recently from fc18781 to 29b4ecd Compare February 27, 2026 11:27
@stackhpc-ci
Copy link
Contributor

stackhpc-ci commented Feb 27, 2026

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output


Warning: Deprecated attribute

  on repositories.tf line 19, in resource "github_repository" "repositories":
  19:       has_downloads,

The attribute "has_downloads" is deprecated. Refer to the provider
documentation for details.
Success! The configuration is valid, but there were some validation warnings
as shown above.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @priteau, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@priteau priteau force-pushed the bump-integrations-github branch 2 times, most recently from 4e90366 to a23026d Compare February 27, 2026 11:53
@priteau priteau changed the title Bump integrations/github to the latest release Bump integrations/github to v6 Feb 27, 2026
@priteau priteau marked this pull request as draft February 27, 2026 12:40
@priteau
Copy link
Member Author

priteau commented Feb 27, 2026

Need to review the proposed Terraform changes now.

@priteau priteau force-pushed the bump-integrations-github branch 6 times, most recently from 3ad16be to d5bcb00 Compare March 6, 2026 10:06
@priteau
Copy link
Member Author

priteau commented Mar 6, 2026

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Terraform configuration to be compatible with version 6 of the integrations/github provider, migrating github_branch_protection resources and ignore_changes lifecycle hooks. However, there are critical security concerns: the private and default_branch attributes were removed from the ignore_changes list without being explicitly defined, which could lead to private repositories being accidentally made public and default branches being reset to main. Additionally, I've noted significant code duplication in terraform/github/branches.tf and suggest moving the new repository configuration change to a separate PR for better focus.

ignore_changes = [
description,
homepage_url,
private,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

The private attribute was removed from the ignore_changes list in the github_repository resource. Since the private attribute is not explicitly set in the resource configuration, Terraform will default it to false (public). This could lead to private repositories being accidentally made public during a Terraform apply. Although visibility is still ignored, the GitHub provider will still send an update for the private attribute if it is not ignored, which will change the repository's visibility on GitHub.

auto_init,
gitignore_template,
license_template,
default_branch,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The default_branch attribute was removed from the ignore_changes list. Since it is not set in the resource configuration, Terraform will default it to main. This could cause Terraform to change the default branch of repositories that use a different branch name (e.g., master, devel), potentially breaking CI/CD pipelines and developer workflows.

Remove use of deprecated github_repository attributes:

- default_branch
- ignore_vulnerability_alerts_during_read
- private

Ignore has_discussions for stackhpc/ansible-collection-cephadm.

Change push_restrictions to restrict_pushes.

Import ansible-slurm-appliance required status checks.
@priteau priteau force-pushed the bump-integrations-github branch from d5bcb00 to 2ec9db7 Compare March 6, 2026 10:39
@priteau priteau marked this pull request as ready for review March 6, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants