Allow Operator to manage ETCd BackupBucket#152
Merged
ske-prow[bot] merged 2 commits intoske-v1.120from Jun 6, 2025
Merged
Conversation
This reverts commit 13bbc31.
ske-prow
bot
added
do-not-merge/hold
Wieneo
changed the title
BackupBucket
Wieneo
changed the title
BackupBucketBackupBucket
Wieneo
force-pushed
the
drop-operator-patch
branch
from
e45e508 to
6ca917f
Compare
ske-prow
bot
added
size/L
Wieneo
force-pushed
the
drop-operator-patch
branch
from
6ca917f to
2e1505d
Compare
This can be dropped with G/G v1.121
Wieneo
force-pushed
the
drop-operator-patch
branch
from
2e1505d to
8b5ce63
Compare
Author
|
/label tide/merge-method-rebase We want to keep the commit messages :) |
ske-prow
bot
added
the
tide/merge-method-rebase
Author
|
/unhold |
ske-prow
bot
removed
the
do-not-merge/hold
maboehm
approved these changes
Jun 6, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maboehm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 91aebb5e06d46959676a00e02683033582327abe |
ske-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR reverts the last remaining patch in our fork.
Which issue(s) this PR fixes:
Fixes JIRA#STACKITSKE-830
Special notes for your reviewer:
After rolling out this version of our fork, we still need to patch the
gardens.operator.gardener.cloudCRD as updating the bucket name is still forbidden by https://github.com/stackitcloud/gardener/blob/13bbc31080c9e2ec736eb48a5d683938ea56d8fc/pkg/apis/operator/v1alpha1/types_garden.go#L287C1-L287C10We currently pull CRDs from upstream, so no way we can fix this in this repository.