Revert "Allow virtual cluster ETCd bucket name to be mutated"#154
Merged
ske-prow[bot] merged 1 commit intoske-v1.120from Jun 11, 2025
Merged
Revert "Allow virtual cluster ETCd bucket name to be mutated"#154ske-prow[bot] merged 1 commit intoske-v1.120from
ske-prow[bot] merged 1 commit intoske-v1.120from
Conversation
This reverts commit 38e0351.
ske-prow
bot
added
kind/enhancement
|
LGTM label has been added. DetailsGit tree hash: 0b649da2571e3db57b9ac146960b29b463c0a9bc |
maboehm
approved these changes
Jun 11, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maboehm, timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR reverts 38e0351 as its not needed anymore.
We rolled out v1.120.1-ske-1 on every stage and migrated to the new
BackupBucket.