[ske-v1.130] Cherry-pick new seed settings#162
Merged
ske-prow[bot] merged 5 commits intoske-v1.130from Oct 31, 2025
Merged
Conversation
…ener#12956) * feat: introduce zonalIngress field to seed settings Signed-off-by: cerealsnow <13483299+cerealsnow@users.noreply.github.com> * feat: restrict istio ingress gateway creation based on zonalIngress field Signed-off-by: cerealsnow <13483299+cerealsnow@users.noreply.github.com> * feat: cleanup namespaces for zonal istio ingress gateways * feat: select global ingress gateway if zonal gateway is disabled Shoots with failureTolerance != zone use the zonal istio ingress gateways. For seeds with disabled zonal gateways, we need to select the global gateway instead. * feat: use global gateways for local dns records if zonal gateways are disabled * docs: document usage of zonalIngress field in Seed API * fix: align pull-gardener-unit tests with managed istio-ingress namespace The istio-ingress namespace is now provisioned as a managed resource, which caused test failures. Added validation to ensure the namespace is deployed as a managed resource. * fix: remove cleanup of namespaces for zonal istio ingress gateways The deployment and cleanup of namespaces for zonal istio ingress gateways is now handeled by the GRM, so a manual cleanup is not necessary anymore. * fix: align pull-gardener-integration tests with zonalIngress Seed API field * docs: add doc string for zonalIngress field in Seed API to external types * feat: add output of make generate * feat: safeguard deletion of unused zonal istio ingress gateways When an operator disables zonal istio ingress gateways, their cleanup is now postponed until it is verified that no Shoots are still referencing them. This prevents the control planes of affected Shoots from becoming unreachable until the next reconciliation. Signed-off-by: cerealsnow <13483299+cerealsnow@users.noreply.github.com> * feat: return error from AreZonalGatewaysInUse and handle it properly Signed-off-by: cerealsnow <13483299+cerealsnow@users.noreply.github.com> * fix: handle NoMatchError for Gateway CRD Signed-off-by: cerealsnow <13483299+cerealsnow@users.noreply.github.com> --------- Signed-off-by: cerealsnow <13483299+cerealsnow@users.noreply.github.com> (cherry picked from commit e414c0d)
ske-prow
bot
added
kind/cherry-pick
Member
Author
|
/hold |
ske-prow
bot
added
the
do-not-merge/hold
…ss for Admin/ViewerKubeconfig credentials (gardener#13298) * Deploy earlier the ClusterRoleBindings granting access for Admin/ViewerKubeconfig credentials * Set the keep-object annotation to let the old MR stop tracking the resources * Migrate CRBs on gardenlet migration * Address review feedback Co-authored-by: Ismail Alidzhikov <9372594+ialidzhikov@users.noreply.github.com> --------- Co-authored-by: vpnachev <vladimir.nachev@sap.com> Co-authored-by: Ismail Alidzhikov <9372594+ialidzhikov@users.noreply.github.com> (cherry picked from commit 3a947d2)
Co-authored-by: Shafeeque E S <shafeeqes@gmail.com> (cherry picked from commit 291c94d)
… MR (gardener#13310) Co-authored-by: vpnachev <vladimir.nachev@sap.com> (cherry picked from commit 9002f97)
Member
Author
|
/unhold |
ske-prow
bot
removed
the
do-not-merge/hold
Member
Author
|
/label tide/merge-method-rebase |
ske-prow
bot
added
the
tide/merge-method-rebase
Member
Author
|
/remove-label tide/merge-method-squash |
ske-prow
bot
removed
the
tide/merge-method-squash
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: d87dad67e45a0def01979fe7ad35a529e8b79834 |
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind cherry-pick
What this PR does / why we need it:
Cherry-pick gardener#13305 to our Gardener version.
To reduce the conflicts, I first cherry-picked gardener#12956.
The ske-v1.130 is based on https://github.com/gardener/gardener/releases/tag/v1.130.1, so this PR also adds the latest cherry-picks from https://github.com/gardener/gardener/releases/tag/v1.130.2 (see gardener/gardener@v1.130.1...v1.130.2).
Which issue(s) this PR fixes:
Part of STACKITSKE-4868
Special notes for your reviewer:
/cc @stackitcloud/ske-gardener
/label tide/merge-method-squash