Skip to content

feat: disable project CreatedBy validation #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ske-prow merged 2 commits into from
Nov 12, 2025
Merged

feat: disable project CreatedBy validation #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9632dd1
feat: diasble project CreatedBy validation
xoxys Nov 12, 2025
6512e2a
remove tests
xoxys Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/apis/core/validation/project.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ func ValidateProjectUpdate(newProject, oldProject *core.Project) field.ErrorList
allErrs = append(allErrs, apivalidation.ValidateObjectMetaUpdate(&newProject.ObjectMeta, &oldProject.ObjectMeta, field.NewPath("metadata"))...)
allErrs = append(allErrs, ValidateProjectWithOpts(newProject, opts)...)

if oldProject.Spec.CreatedBy != nil {
allErrs = append(allErrs, apivalidation.ValidateImmutableField(newProject.Spec.CreatedBy, oldProject.Spec.CreatedBy, field.NewPath("spec", "createdBy"))...)
}
if oldProject.Spec.Namespace != nil {
allErrs = append(allErrs, apivalidation.ValidateImmutableField(newProject.Spec.Namespace, oldProject.Spec.Namespace, field.NewPath("spec", "namespace"))...)
}
Expand Down
24 changes: 0 additions & 24 deletions pkg/apis/core/validation/project_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,30 +645,6 @@ var _ = Describe("Project Validation Tests", func() {
Entry("no change (same value)", ptr.To("garden-dev"), ptr.To("garden-dev"), BeEmpty()),
)

It("should forbid Project updates trying to change the createdBy field", func() {
newProject := prepareProjectForUpdate(project)
newProject.Spec.CreatedBy.Name = "some-other-user"

errorList := ValidateProjectUpdate(newProject, project)

Expect(errorList).To(ConsistOf(PointTo(MatchFields(IgnoreExtras, Fields{
"Type": Equal(field.ErrorTypeInvalid),
"Field": Equal("spec.createdBy"),
}))))
})

It("should forbid Project updates trying to change the createdBy field", func() {
newProject := prepareProjectForUpdate(project)
newProject.Spec.CreatedBy.Name = "some-other-user"

errorList := ValidateProjectUpdate(newProject, project)

Expect(errorList).To(ConsistOf(PointTo(MatchFields(IgnoreExtras, Fields{
"Type": Equal(field.ErrorTypeInvalid),
"Field": Equal("spec.createdBy"),
}))))
})

It("should forbid Project updates trying to reset the owner field", func() {
newProject := prepareProjectForUpdate(project)
newProject.Spec.Owner = nil
Expand Down