Skip to content

Comments

Add minimal make generate target#72

Merged
ske-prow[bot] merged 1 commit intomainfrom
make-generate
Dec 15, 2025
Merged

Add minimal make generate target#72
ske-prow[bot] merged 1 commit intomainfrom
make-generate

Conversation

@xoxys
Copy link
Member

@xoxys xoxys commented Dec 15, 2025

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

Fixes e.g. #65

Special notes for your reviewer:

The PR just adds a minimal make generate target to fulfill the renovate config. As an alternative, we could also adjust the renovate config for this repo. But I guess we will need mocks sooner or later anyway, so Ive chosen this way.

@ske-prow ske-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2025
@xoxys xoxys added the kind/enhancement Enhancement, improvement, extension label Dec 15, 2025
@ske-prow ske-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 15, 2025
@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2025
@ske-prow
Copy link

ske-prow bot commented Dec 15, 2025

LGTM label has been added.

DetailsGit tree hash: de425b5bc1f7fa0e4ddfa3357999d7c6d0f2e6a9

@ske-prow
Copy link

ske-prow bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2025
@ske-prow ske-prow bot merged commit 3c571c8 into main Dec 15, 2025
3 checks passed
@breuerfelix breuerfelix deleted the make-generate branch February 18, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants