Skip to content

Comments

change region from secret to provider spec#74

Merged
ske-prow[bot] merged 4 commits intomainfrom
add-region
Dec 18, 2025
Merged

change region from secret to provider spec#74
ske-prow[bot] merged 4 commits intomainfrom
add-region

Conversation

@breuerfelix
Copy link
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension labels Dec 18, 2025
@ske-prow
Copy link

ske-prow bot commented Dec 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ske-prow ske-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2025
@breuerfelix breuerfelix marked this pull request as ready for review December 18, 2025 12:02
@ske-prow ske-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2025
@aniruddha2000
Copy link
Member

/lgtm

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@ske-prow
Copy link

ske-prow bot commented Dec 18, 2025

LGTM label has been added.

DetailsGit tree hash: c11a1af2adf29a159816581dfcabb4ee17e83a43

@ske-prow ske-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow ske-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@ske-prow ske-prow bot requested a review from aniruddha2000 December 18, 2025 13:56
@ske-prow ske-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
@breuerfelix breuerfelix requested a review from a team December 18, 2025 14:08
@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@ske-prow
Copy link

ske-prow bot commented Dec 18, 2025

LGTM label has been added.

DetailsGit tree hash: 35a62b65de6a257164e687bc82edec39048d21c5

@ske-prow
Copy link

ske-prow bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aniruddha2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2025
@ske-prow ske-prow bot merged commit bd425db into main Dec 18, 2025
3 checks passed
@breuerfelix breuerfelix deleted the add-region branch February 18, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants