Skip to content

Comments

try fetching server before creating#78

Merged
ske-prow[bot] merged 5 commits intomainfrom
fix-race-condition
Jan 14, 2026
Merged

try fetching server before creating#78
ske-prow[bot] merged 5 commits intomainfrom
fix-race-condition

Conversation

@breuerfelix
Copy link
Member

@breuerfelix breuerfelix commented Jan 8, 2026

How to categorize this PR?

/kind bug

What this PR does / why we need it:
When creating new clusters sometimes the mcm will create 2 server with the same name. These kubelets are then fighting for the same Node CR.

The Openstack MCM is doing a similar thing.

Special notes for your reviewer:

Breaking changes:

Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow
Copy link

ske-prow bot commented Jan 8, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ske-prow ske-prow bot added kind/bug Bug do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2026
@breuerfelix breuerfelix marked this pull request as ready for review January 9, 2026 14:23
@ske-prow ske-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2026
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@nschad
Copy link
Contributor

nschad commented Jan 14, 2026

/lgtm

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@ske-prow
Copy link

ske-prow bot commented Jan 14, 2026

LGTM label has been added.

DetailsGit tree hash: ba6fc4bd1125e9a4778012299feebfdd78129e4c

Co-authored-by: Niclas Schad <niclas.schad@gmail.com>
@ske-prow ske-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@ske-prow ske-prow bot requested a review from nschad January 14, 2026 13:01
@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@ske-prow
Copy link

ske-prow bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow
Copy link

ske-prow bot commented Jan 14, 2026

LGTM label has been added.

DetailsGit tree hash: d710e0090ea4ed8fad3fa14ef962b6f6f7526bef

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2026
@ske-prow ske-prow bot merged commit f69b95a into main Jan 14, 2026
3 checks passed
@breuerfelix breuerfelix deleted the fix-race-condition branch February 18, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants