Skip to content

Comments

remove-pointer-functions#92

Merged
ske-prow[bot] merged 1 commit intomainfrom
remove-pointer-functions
Jan 23, 2026
Merged

remove-pointer-functions#92
ske-prow[bot] merged 1 commit intomainfrom
remove-pointer-functions

Conversation

@breuerfelix
Copy link
Member

@breuerfelix breuerfelix commented Jan 23, 2026

How to categorize this PR?

/kind technical-debt

What this PR does / why we need it:
These are not needed since everywhere we use it, we have a variable before so we can use the & operator.

Special notes for your reviewer:

Breaking changes:

Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow ske-prow bot added kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2026
@breuerfelix
Copy link
Member Author

tested in ondemand

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026
@ske-prow
Copy link

ske-prow bot commented Jan 23, 2026

LGTM label has been added.

DetailsGit tree hash: 960d5e6f3a14d6c68415014cca1acb64fe30c224

@ske-prow
Copy link

ske-prow bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aniruddha2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2026
@ske-prow ske-prow bot merged commit 654269f into main Jan 23, 2026
3 checks passed
@breuerfelix breuerfelix deleted the remove-pointer-functions branch January 23, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants