Merged
Conversation
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
ske-prow
bot
added
kind/technical-debt
Member
Author
|
tested on ondemand |
nschad
approved these changes
Jan 26, 2026
|
LGTM label has been added. DetailsGit tree hash: fed59848ea1705b409ac6ffb7508ac4fe0e731a3 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nschad The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
bot
added
the
approved
breuerfelix
added a commit
that referenced
this pull request
Jan 26, 2026
* use stackitProviderName everywhere Signed-off-by: Felix Breuer <f.breuer94@gmail.com> * extract secret extraction into function Signed-off-by: Felix Breuer <f.breuer94@gmail.com> --------- Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
breuerfelix
added a commit
that referenced
this pull request
Jan 26, 2026
* use stackitProviderName everywhere Signed-off-by: Felix Breuer <f.breuer94@gmail.com> * extract secret extraction into function Signed-off-by: Felix Breuer <f.breuer94@gmail.com> --------- Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
breuerfelix
added a commit
that referenced
this pull request
Jan 26, 2026
* use stackitProviderName everywhere Signed-off-by: Felix Breuer <f.breuer94@gmail.com> * extract secret extraction into function Signed-off-by: Felix Breuer <f.breuer94@gmail.com> --------- Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
breuerfelix
added a commit
that referenced
this pull request
Jan 26, 2026
* use stackitProviderName everywhere Signed-off-by: Felix Breuer <f.breuer94@gmail.com> * extract secret extraction into function Signed-off-by: Felix Breuer <f.breuer94@gmail.com> --------- Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
breuerfelix
added a commit
that referenced
this pull request
Jan 27, 2026
* use stackitProviderName everywhere Signed-off-by: Felix Breuer <f.breuer94@gmail.com> * extract secret extraction into function Signed-off-by: Felix Breuer <f.breuer94@gmail.com> --------- Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind technical-debt
What this PR does / why we need it:
The
project-idandserviceaccount.jsonkeys were used as plain string throughout the whole repo. Since we use constants now, it is not that error prone.Special notes for your reviewer:
Breaking changes: