Merged
Conversation
ske-prow
bot
added
kind/technical-debt
breuerfelix
force-pushed
the
declutter-secret
branch
4 times, most recently
from
95ff206 to
36bb481
Compare
ske-prow
bot
added
size/L
breuerfelix
force-pushed
the
declutter-secret
branch
from
36bb481 to
ab4569a
Compare
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
breuerfelix
force-pushed
the
declutter-secret
branch
from
ab4569a to
cd531d8
Compare
Member
Author
|
tested in ondemand |
|
LGTM label has been added. DetailsGit tree hash: 7b81f8c05b6584e5008c058db73b93e6e262bd1a |
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breuerfelix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind technical-debt
What this PR does / why we need it:
Proving networkID from the Secret feels odd. We do not want that functionality. Other MCMs like GCP only provider userData aswell via Secret.
Special notes for your reviewer:
Breaking changes: