Skip to content

Comments

use kubernetes.io as default label#97

Merged
ske-prow[bot] merged 1 commit intomainfrom
default-labels
Jan 27, 2026
Merged

use kubernetes.io as default label#97
ske-prow[bot] merged 1 commit intomainfrom
default-labels

Conversation

@breuerfelix
Copy link
Member

How to categorize this PR?

/kind technical-debt

What this PR does / why we need it:
Based on ADR67 we decided to use kubernetes.io as the default label. This will be made configureable in a later story.

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow bot added kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2026
@breuerfelix breuerfelix force-pushed the default-labels branch 3 times, most recently from da10c7b to 4c11df2 Compare January 27, 2026 08:34
| `kubernetes.io/cluster` | Cluster ID | Identify which cluster owns this server |
| `kubernetes.io/machine` | Machine CR name | Map server to Kubernetes Machine |
| `kubernetes.io/machineclass` | MachineClass name | Map server to MachineClass for orphan detection |
| `kubernetes.io/worker` | Worker name | Identify which worker handles this machine |
Copy link
Member

@dergeberl dergeberl Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need for this label?

@breuerfelix
Copy link
Member Author

it works
image

Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026
@ske-prow
Copy link

ske-prow bot commented Jan 27, 2026

LGTM label has been added.

DetailsGit tree hash: f2b9de82b25ae342ca4bdc679de3ccf2756caf0f

@ske-prow
Copy link

ske-prow bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dergeberl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2026
@ske-prow ske-prow bot merged commit 73cc4a1 into main Jan 27, 2026
3 checks passed
@breuerfelix breuerfelix deleted the default-labels branch February 18, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants