test(vision): add modality contract fixtures and checks#276
Closed
a-klos wants to merge 1 commit intochore/vision-00-adr-flags-baselinefrom
Closed
test(vision): add modality contract fixtures and checks#276a-klos wants to merge 1 commit intochore/vision-00-adr-flags-baselinefrom
a-klos wants to merge 1 commit intochore/vision-00-adr-flags-baselinefrom
Conversation
robodev-r2d2
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces contract tests to ensure the consistency and validity of modality metadata across different extraction paths. It adds a new test suite that validates sample fixtures for various modalities (TEXT, TABLE, IMAGE), including both valid and invalid cases, and enforces schema requirements for each. The most important changes are as follows:
Test Suite Implementation:
modality_contract_test.py) that loads JSON fixtures and validates that modality metadata conforms to required schemas, including special handling for IMAGE modality and checks for uniqueness of fixture names.Test Fixtures for Modality Validation:
text_valid.json) to verify correct schema for text pieces.table_valid.json) to test schema compliance for table pieces.Test Fixtures for IMAGE Modality:
image_legacy_base64_valid.json).image_reference_valid.json).image_invalid_missing_payload.json).