fix(key_flow): Add 5 second leeway to refresh access tokens early

[ptrckmllr]

Description

This PR attempts to fix #2193

Checklist

• Issue was linked above
• No generated code was adjusted manually (check comments in file header)
• Changelogs
  • Changelog in the root directory was adjusted (see here)
  • Changelog(s) of the service(s) were adjusted (see e.g. here)
• Code format was applied: make fmt
• Examples were added / adjusted (see examples/ directory)
• Unit tests got implemented or updated
• Unit tests are passing: make test (will be checked by CI)
• No linter issues: make lint (will be checked by CI)

[ptrckmllr]

It seems this breaks the key_flow_continuous_refresh_test.go tests due to the extremly small token lifetimes used in there.

Is increasing token lifetimes (5+ seconds) in those tests a feasible approach?

[malteehrlen]

thanks for this, we have been suffering expired tokens every now and then <3

[ptrckmllr]

Moved the new variable to KeyFlow struct, set it during Init(...) and validate it.

Now the key_flow_continuous_refresh_test.go do work as expected again, as it uses the default 0 value.

This raises questions about the robustness of these tests though, as they do not call the KeyFlow.Init(...) func and instead just create the KeyFlow struct.

Should I create a separate issue or is this the intended way for the tests to run?

[github-actions]

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

[Fyusel]

Thank you for contributing!
Looks good, do you want to add the changelogs as well then this can be merged.

Regarding your open topic, I created a separate ticket on our side to have a look at this.

[ptrckmllr]

Thank you for contributing! Looks good, do you want to add the changelogs as well then this can be merged.

Regarding your open topic, I created a separate ticket on our side to have a look at this.

Changelog has been updated.