Skip to content

fix(observability): Adjusted wait handler: sometimes GetInstanceExecu… #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fyusel merged 1 commit into from
Aug 14, 2025
Merged

fix(observability): Adjusted wait handler: sometimes GetInstanceExecu… #3500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions services/observability/wait/wait.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ func CreateInstanceWaitHandler(ctx context.Context, a APIClientInterface, instan
if err != nil {
return false, nil, err
}
if s == nil {
return false, nil, nil
}
if s.Id == nil || s.Status == nil {
return false, nil, fmt.Errorf("could not get instance id or status from response for project %s and instance %s", projectId, instanceId)
}
Expand All @@ -59,6 +62,9 @@ func UpdateInstanceWaitHandler(ctx context.Context, a APIClientInterface, instan
if err != nil {
return false, nil, err
}
if s == nil {
return false, nil, nil
}
if s.Id == nil || s.Status == nil {
return false, nil, fmt.Errorf("could not get instance id or status from response for project %s and instance %s", projectId, instanceId)
}
Expand All @@ -82,6 +88,9 @@ func DeleteInstanceWaitHandler(ctx context.Context, a APIClientInterface, instan
if err != nil {
return false, nil, err
}
if s == nil {
return false, nil, nil
}
if s.Id == nil || s.Status == nil {
return false, nil, fmt.Errorf("could not get instance id or status from response for project %s and instance %s", projectId, instanceId)
}
Expand Down
Loading