Skip to content

Fix unnecessary keepalived switches due to unhealthy condition#423

Merged
dergeberl merged 1 commit intomainfrom
fixFlappingKeepalived
Oct 25, 2024
Merged

Fix unnecessary keepalived switches due to unhealthy condition#423
dergeberl merged 1 commit intomainfrom
fixFlappingKeepalived

Conversation

@dergeberl
Copy link
Member

@dergeberl dergeberl commented Oct 24, 2024

In some cases, a change (like nodes or ports) triggered an unnecessary keepalived failover.

It happened that the envoy did not have the new snapshot version here:

// check envoy snapshot and update condition
if changed {
helper.CheckEnvoyVersion(conditions, &snapshot)
} else {
helper.CheckEnvoyVersion(conditions, oldSnapshot)
}

This results in a false EnvoyUpToDate condition. That will not be fixed until the requeue time (30s) but the keepalived healthcheck of yawollet fails which results in an unnecessary keepalived failover.

I think the best way to solve this is to use the same check for unready conditions and return an error to requeue with backoff.

@dergeberl dergeberl merged commit 37f1061 into main Oct 25, 2024
@dergeberl dergeberl deleted the fixFlappingKeepalived branch October 25, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments