fix lbm hash change due to addition of proxy_url#432
Merged
Conversation
MichaelEischer
requested review from
Kumm-Kai,
dergeberl,
einfachnuralex,
maboehm and
timebertt
as code owners
The hash is calculated by hashing the json serialization of a part of the LB spec. As `proxyUrl` was not marked as omitempty, this changed the serialized value even when proxyUrl was not set.
MichaelEischer
force-pushed
the
fix-hash-change
branch
from
25ff80e to
58907ac
Compare
maboehm
reviewed
Oct 31, 2024
maboehm
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#427 added support for configuring a
proxy_urlfor loki logs. However, this caused the lb hash to change and therefore unnecessarily roll all yawol LBs. The hash is calculated by hashing the json serialization of a part of the LB spec. AsproxyUrlwas not marked asomitemptythis changed the serialized value even when proxyUrl was not set.