Skip to content

Stop dropping status.FloatingID when OpenStack API returns 404 #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kumm-Kai merged 3 commits into from
Dec 4, 2024
Merged

Stop dropping status.FloatingID when OpenStack API returns 404 #449

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
303e6d0
Remove status removal
Dec 2, 2024
92b586b
Improve error handling
Dec 3, 2024
78071ef
Adapt PR suggestions
Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions controllers/yawol-controller/loadbalancer/loadbalancer_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,16 +421,16 @@ func (r *Reconciler) reconcileFIP(
// Get FIP
var fip *floatingips.FloatingIP
if fip, err = openstackhelper.GetFIPByID(ctx, fipClient, *lb.Status.FloatingID); err != nil {
switch err.(type) {
case gophercloud.ErrUnexpectedResponseCode, gophercloud.ErrResourceNotFound:
r.Log.Info("fip not found in openstack", "fip", *lb.Status.FloatingID)
// fip not found by ID, remove it from status and trigger reconcile
if err := helper.RemoveFromLBStatus(ctx, r.Status(), lb, "floatingID"); err != nil {
return false, fmt.Errorf("failed to remove FIP from lb status: %w", err)
switch e := err.(type) {
case gophercloud.ErrUnexpectedResponseCode:
code := e.GetStatusCode()
if code == 404 {
return false, fmt.Errorf("fip not found: %w", err)
} else {
return false, fmt.Errorf("unexpected gophercloud error occurred: %w", err)
}
return true, err
default:
r.Log.Info("unexpected error occurred")
r.Log.Info("unexpected go error occurred", "error: ", err)
return false, kubernetes.SendErrorAsEvent(r.RecorderLB, err, lb)
}
}
Expand Down Expand Up @@ -497,7 +497,10 @@ func (r *Reconciler) assignOrCreateFIP(
}

// try to find FIP by name
fip, _ = openstackhelper.GetFIPByName(ctx, fipClient, *lb.Status.FloatingName)
fip, err = openstackhelper.GetFIPByName(ctx, fipClient, *lb.Status.FloatingName)
if err != nil {
r.Log.Error(err, "retrieving FIP by Name failed")
}
if fip != nil {
r.Log.Info("Found FloatingIP by Name", "lb", lb.Name)
return helper.PatchLBStatus(
Expand Down