Conversation
nightlyone
reviewed
Dec 11, 2022
0fac0d0 to
ab2d24f
Compare
6cab231 to
4451a4b
Compare
…from the secretRef
…ork if default is overwritten
86635be to
b059989
Compare
nschad
reviewed
Jan 2, 2023
breuerfelix
reviewed
Jan 2, 2023
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller.go
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller.go
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #50
Changes in yawol-controller:
lb.spec.infrastructure.floatingNetIDandlb.spec.infrastructure.networkIDtolb.spec.infrastructure.defaultNetworklb.spec.infrastructure.floatingNetIDandlb.spec.infrastructure.networkIDlbm.status.portIDtolbm.status.defaultPortIDlbm.status.portIDlbm.status.defaultPortNameto be aligned with the LoadBalancer Objectlb.spec.infrastructure.additionalNetworks) to server without any precreated port (precreation is not needed because there are no special settings for this portslb.status.portIPto have easy access to the IP from the LoadBalancer Portlbm.status.defaultPortIPto have easy access to the IP from the LoadBalancerMachine Portlb.infrastructure.projectIDto overwrite the openstack projectID from the secretRefChanges in yawol-cloud-controller:
yawol.stackit.cloud/additionalNetworksannotation to add additionalNetworks to thelbobjectyawol.stackit.cloud/floatingNetworkIDannotation to overwrite default floatingNetworkIDyawol.stackit.cloud/defaultNetworkIDannotation to overwrite the default network which is set by theyawol-cloud-controller. If enabled it will automatically add the default network ID from theyawol-cloud-controllertolb.spec.infrastructure.additionalNetworksyawol.stackit.cloud/skipCloudControllerDefaultNetworkIDto prevent that the default network ID from theyawol-cloud-controllertolb.spec.infrastructure.additionalNetworksifyawol.stackit.cloud/defaultNetworkIDis setyawol.stackit.cloud/projectIDto add thelb.infrastructure.projectID. This field cant be changed.Changes in yawollet:
DnsLookupFamilyinClustertoAuto(which is also the envoy default)Changes in yawollet image:
go.mod
Co-authored-by: @breuerfelix @einfachnuralex