Conversation
aashutoshrathi
requested changes
Sep 5, 2024
Member
aashutoshrathi
left a comment
aashutoshrathi
left a comment
There was a problem hiding this comment.
Few changes other changes than comments:
- Use the same formatting as existing project
2 spacesover4 spaces or Tabwhich ever you use, it'll reduce diff.
Question:
- Will this help anyone? As still the ENS is only visible to the user themselves and not their opponent?
| {!!walletAddress && ( | ||
| <div className="flex gap-4 items-center"> | ||
| <p className="font-mono"> | ||
| <b>AA Wallet:</b> {ensName || formatHash(walletAddress)} |
Member
There was a problem hiding this comment.
Few changes here, the walletAddress will be the user's non-custodial wallet address.
So you might have to show it like here
Since this wallet is Injected and the one with connectorType as embedded is AA Wallet.
| import Link from "next/link"; | ||
| import { Button } from "./ui/button"; | ||
| import { useEffect, useState } from "react"; | ||
| import { ethers } from "ethers"; |
Member
There was a problem hiding this comment.
I don't think ethers is dep in game. You might have to use viem or install this.
Co-authored-by: Aashutosh Rathi <aashutoshrathi@gmail.com>
Author
we can enable it to show to opponent as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #16
Added ENS support to show if the wallet has a ENS id else address will be displayed