ROX-30609: Move Central RDS core configurations to envs#2414
Merged
Conversation
…rsion-configurable
kurlov
changed the title
johannes94
requested changes
Sep 1, 2025
kovayur
approved these changes
Sep 4, 2025
Contributor
kovayur
left a comment
kovayur
left a comment
There was a problem hiding this comment.
Feel free to ignore my remarks.
Co-authored-by: Yury Kovalev <8366110+kovayur@users.noreply.github.com>
johannes94
reviewed
Sep 4, 2025
Contributor
johannes94
left a comment
johannes94
left a comment
There was a problem hiding this comment.
@kurlov The changes look good to me, I'll approve as soon as CI is fixed.
…rsion-configurable
kurlov
commented
Sep 5, 2025
| - Container images are built for linux/amd64 platform | ||
| - Use `./scripts/fmcurl` for API testing | ||
| - Fleet manager stores state in PostgreSQL, fleetshard-sync is stateless No newline at end of file | ||
| - Fleet manager stores state in PostgreSQL, fleetshard-sync is stateless |
Member
Author
There was a problem hiding this comment.
CI complained missing new line
johannes94
approved these changes
Sep 5, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kovayur, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kurlov
deleted the
akurlov/ROX-30609-make-central-rds-engine-version-configurable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the following configs to envs:
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual