ROX-30728: add fallback to internal k8s svc for FM/FS k8s auth#2421
Merged
johannes94 merged 5 commits intomainfrom Sep 2, 2025
Merged
ROX-30728: add fallback to internal k8s svc for FM/FS k8s auth#2421johannes94 merged 5 commits intomainfrom
johannes94 merged 5 commits intomainfrom
Conversation
kovayur
reviewed
Sep 2, 2025
Contributor
kovayur
left a comment
There was a problem hiding this comment.
The change looks good and covers more use cases. One question: Can we remove the override defined in getJwksURI and only rely on the new one?
Contributor
Author
|
@kovayur Applied the suggested changes, thanks. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kovayur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the KubernetesIssuer for FM <> FS auth.
Current behavior:
New behavior:
kubernetes.default.svcas a Host insteadThis is required as a step to use ROSA HCP for e2e test, because infra ROSA HCPs do not publicly expose the JWKS given in the openid configuration, but using the internal svc works.
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
TODO: Add manual testing efforts