Add design proposal to remove sentry code#2442
Merged
Conversation
ebensh
force-pushed
the
ebenshet/design-proposal-remove-sentry-code
branch
from
4518d70 to
79d0fd6
Compare
ebensh
force-pushed
the
ebenshet/design-proposal-remove-sentry-code
branch
from
79d0fd6 to
3f8b362
Compare
ebensh
force-pushed
the
ebenshet/design-proposal-remove-sentry-code
branch
from
3f8b362 to
28aef81
Compare
ebensh
changed the base branch from
main
to
ebenshet/creating-sub-agent-team
ebensh
force-pushed
the
ebenshet/creating-sub-agent-team
branch
from
0066f90 to
8ba6439
Compare
ebensh
force-pushed
the
ebenshet/design-proposal-remove-sentry-code
branch
from
28aef81 to
f0c97a9
Compare
…rompt: There is unused code in this repository that was added to be able to send logs to Sentry. We do not use this behavior. Please create a design proposal in @.design-proposals/remove-dead-code-sentry.md to remove it. That will likely include an enumeration of locations in the code related to the Sentry logging feature, configuration for Sentry tokens/keys, out of date documentation about the feature, references in Makefiles, and go modules. Don't actually do the modification yet - just plan it out by enumerating the files and such you'd need to touch to make the change. We'll then hand the design to a more junior engineer to actually do the removal work.
ebensh
force-pushed
the
ebenshet/design-proposal-remove-sentry-code
branch
from
f0c97a9 to
da5e885
Compare
kurlov
approved these changes
Sep 26, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt:
There is unused code in this repository that was added to be able to send logs to Sentry. We do not use this behavior. Please create a design proposal in @.design-proposals/remove-dead-code-sentry.md to remove it. That will likely include an enumeration of locations in the code related to the Sentry logging feature, configuration for Sentry tokens/keys, out of date documentation about the feature, references in Makefiles, and go modules. Don't actually do the modification yet - just plan it out by enumerating the files and such you'd need to touch to make the change. We'll then hand the design to a more junior engineer to actually do the removal work.