Add design proposal to clean up Fleet Manager configuration#2444
Merged
Conversation
ebensh
force-pushed
the
ebenshet/design-proposal-configuration-cleanup
branch
from
b986800 to
55e1cdd
Compare
ebensh
force-pushed
the
ebenshet/design-proposal-configuration-cleanup
branch
from
55e1cdd to
0502b61
Compare
ebensh
changed the base branch from
main
to
ebenshet/creating-sub-agent-team
ebensh
force-pushed
the
ebenshet/creating-sub-agent-team
branch
from
0066f90 to
8ba6439
Compare
ebensh
force-pushed
the
ebenshet/design-proposal-configuration-cleanup
branch
from
0502b61 to
b414269
Compare
ebensh
force-pushed
the
ebenshet/design-proposal-configuration-cleanup
branch
from
b414269 to
8d1d8b4
Compare
kurlov
approved these changes
Sep 26, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…200~It's a new day. Please take on the role of @.agents/config-expert-river.md and analyze the way we load configuration into the Fleet Manager. I've provided the service credentials files we actually use in our secrets manager in @.tmp/vault_configs/integration-secret.yaml @.tmp/vault_configs/stage-secret.json and @.tmp/vault_configs/prod-secret.json . Please identify improvements - some examples might include key/values that we provide that are no longer read, key/values that are still required and so we provide dummy values, or fields where there's only ever one value set, and we could easily hardcode it. Let me know your recommendations for cleanup in a new markdown file called .design-proposals/configuration-cleanup.md
ebensh
force-pushed
the
ebenshet/design-proposal-configuration-cleanup
branch
from
8d1d8b4 to
88f2f6b
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I provided Claude with a sanitized version of our dataplane configuration from Integration, Stage, and Production secrets in the App-Interface Vault, and asked Claude (and the appropriate sub-agent) to examine the actual configuration values, our configuration libraries, etc. for what values are used.
This actually led to identifying that the sentry logging behavior exists, which led to the next PR to propose its deletion and cleanup.
Prompt:
Adding design plan to clean up configuration based on this prompt: �[200~It's a new day. Please take on the role of @.agents/config-expert-river.md and analyze the way we load configuration into the Fleet Manager. I've provided the service credentials files we actually use in our secrets manager in @.tmp/vault_configs/integration-secret.yaml @.tmp/vault_configs/stage-secret.json and @.tmp/vault_configs/prod-secret.json . Please identify improvements - some examples might include key/values that we provide that are no longer read, key/values that are still required and so we provide dummy values, or fields where there's only ever one value set, and we could easily hardcode it. Let me know your recommendations for cleanup in a new markdown file called .design-proposals/configuration-cleanup.md