Add ExternalDNS deployment for OpenShift clusters#2448
Merged
Conversation
Contributor
Author
|
/retest |
johannes94
approved these changes
Oct 6, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
/retest |
3 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
|
/retest |
This change enables automatic deployment of ExternalDNS via ArgoCD when running e2e tests on OpenShift clusters (including OpenShift CI). Key changes: - Add ArgoCD Application manifest to deploy ExternalDNS from acscs-manifests - Create helper script to fetch cluster's Infrastructure name for unique naming - Update bootstrap.sh to deploy ExternalDNS on OpenShift clusters The ExternalDNS instance uses the Infrastructure CR's infrastructureName to generate a globally unique name, preventing DNS record conflicts across different clusters/CI jobs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ludydoo
force-pushed
the
lcleroux/add-external-dns-for-openshift-ci
branch
from
b4088eb to
bca4aab
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables automatic deployment of ExternalDNS via ArgoCD when running e2e tests on OpenShift clusters (including OpenShift CI).
Changes
dev/env/manifests/external-dns/00-application.yaml): Deploys ExternalDNS from acscs-manifests repository with unique instance namingdev/env/scripts/get-infrastructure-name.sh): Fetches the cluster's Infrastructure CR name to generate globally unique ExternalDNS instance namesdev/env/scripts/bootstrap.sh): Conditionally deploys ExternalDNS on OpenShift clustersImplementation Details
infrastructureNamefield for unique namingTest plan
🤖 Generated with Claude Code