Skip to content

ROX-31200: Add renovate config for konflux bot#2454

Merged
kurlov merged 1 commit intomainfrom
akurlov/ROX-31200-configure-konflux-bot-prs
Oct 8, 2025
Merged

ROX-31200: Add renovate config for konflux bot#2454
kurlov merged 1 commit intomainfrom
akurlov/ROX-31200-configure-konflux-bot-prs

Conversation

@kurlov
Copy link
Copy Markdown
Member

@kurlov kurlov commented Oct 8, 2025

Description

Add configuration for Kofnlux bot PRs

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

],
},
"enabledManagers": [
"tekton",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, kofnlux bot also opens PRs for updating go packages and docker base images.
For go packages we should rely on dependabot.
Not sure about docker base images. We might want to stay on specific rhel version but we can use konflux just to bump minor versions updates and/or use it as an indicator that we need to consider an upgrade for the base image. What is your opinion about docker base images?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I've also seen dependabot update base images previously. We should definitely only have one bot being responsible for that.

I'd say we should take the bot that's easier for us to configure to work for internal / RH registry base images.

@@ -0,0 +1,61 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the file path .github/renovate.json5 and not just .github/renovate.json?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it because other stackrox repos have .json5. But .json is also a valid option https://docs.renovatebot.com/configuration-options/

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov
Copy link
Copy Markdown
Member Author

kurlov commented Oct 8, 2025

e2e tests are no related to these changes

@kurlov
Copy link
Copy Markdown
Member Author

kurlov commented Oct 8, 2025

/override ci/prow/e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 8, 2025

@kurlov: Overrode contexts on behalf of kurlov: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kurlov kurlov merged commit 76cc964 into main Oct 8, 2025
14 checks passed
@kurlov kurlov deleted the akurlov/ROX-31200-configure-konflux-bot-prs branch October 8, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants