Skip to content

feat(dp-terraform)!: remove subcharts#2455

Merged
kovayur merged 1 commit intomainfrom
yury/delete-dp-terraform-subcharts
Oct 15, 2025
Merged

feat(dp-terraform)!: remove subcharts#2455
kovayur merged 1 commit intomainfrom
yury/delete-dp-terraform-subcharts

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Oct 8, 2025

Description

Refers to ROX-31000, ROX-31001, ROX-31003, ROX-31004.
Delete subcharts moved to ArgoCD.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci openshift-ci bot added the approved label Oct 8, 2025
@kovayur kovayur force-pushed the yury/delete-dp-terraform-subcharts branch from 2507c99 to 29b2a21 Compare October 8, 2025 11:55
@kovayur kovayur force-pushed the yury/delete-dp-terraform-subcharts branch from 29b2a21 to 2533aba Compare October 8, 2025 12:02
@kovayur kovayur force-pushed the yury/delete-dp-terraform-subcharts branch from 2533aba to 5bc006a Compare October 8, 2025 15:46
@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Oct 9, 2025

/retest

2 similar comments
@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Oct 10, 2025

/retest

@johannes94
Copy link
Copy Markdown
Contributor

/retest

Refers to ROX-31000, ROX-31001, ROX-31003, ROX-31004
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit a82d9bf into main Oct 15, 2025
19 checks passed
@kovayur kovayur deleted the yury/delete-dp-terraform-subcharts branch October 15, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants