ROX-31204: Standalone emailsender chart

[kovayur]

Description

Move emailsender from the dp-terraform chart to a dedicated chart.

Checklist (Definition of Done)

• Unit and integration tests added
• Added test description under Test manual
• Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
• CI and all relevant tests are passing
• Add the ticket number to the PR title if available, i.e. ROX-12345: ...
• Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
• Add secret to app-interface Vault or Secrets Manager if necessary
• RDS changes were e2e tested manually
• Check AWS limits are reasonable for changes provisioning new resources
• (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

[kovayur]

/retest

[johannes94]

Just for my understanding. For this PR we'll have the emailsender be it's own chart outside dp-terraform but still applied through Addon. Then later on we're going to move it to Argo, right?

[kovayur]

We keep the helm chart outside dp-terraform in acs-fleet-manager. We create an application in our gitops repo that references this chart.
Currently the dp-terraform image tag is pinned in the addon, so this change will have no effect on the Addon.

[johannes94]

Understood from what you shared yesterday in the 1:1.

I was referring to the time in between until we have the Argo App referencing this. In other words I wanted to understand what we would have to do in case we urgently wanted to fix something for the emailsender while we don't have the Argo App yet, and still rely on the addon installing the chart.

[kovayur]

Emailsender images are still updated as before, only the chart remains pinned. If the Argo app is delayed and we need to fix the dp-terraform chart, I can revert this change.
To be on the safe side, I could create an ArgoCD app that points to this branch and make sure it works on integration before merging.

[kovayur]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [johannes94,kovayur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment