Skip to content

ROX-31353: Make RHSSO base url configurable#2467

Merged
kovayur merged 1 commit intomainfrom
yury/ROX-31353-iam-config
Oct 22, 2025
Merged

ROX-31353: Make RHSSO base url configurable#2467
kovayur merged 1 commit intomainfrom
yury/ROX-31353-iam-config

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Oct 21, 2025

Description

Add RHSSO base url parameters to the service template to make it configurable.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur force-pushed the yury/ROX-31353-iam-config branch from 365ed96 to a8f507b Compare October 21, 2025 19:35
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit ff98cac into main Oct 22, 2025
14 checks passed
@kovayur kovayur deleted the yury/ROX-31353-iam-config branch October 22, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants