Skip to content

ROX-31105: Fix InternalCentralIDs reading#2478

Merged
kurlov merged 1 commit intomainfrom
akurlov/ROX-31105-fix-centralid-reading-add-log-msg
Nov 26, 2025
Merged

ROX-31105: Fix InternalCentralIDs reading#2478
kurlov merged 1 commit intomainfrom
akurlov/ROX-31105-fix-centralid-reading-add-log-msg

Conversation

@kurlov
Copy link
Copy Markdown
Member

@kurlov kurlov commented Oct 31, 2025

Description

Fix parsing env for InternalCentralIDs. The StringSliceVar should be used when multiple values separated by comma. Also add logging for flag values

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

N/A

@openshift-ci openshift-ci bot added the lgtm label Oct 31, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov
Copy link
Copy Markdown
Member Author

kurlov commented Nov 1, 2025

/retest

1 similar comment
@kurlov
Copy link
Copy Markdown
Member Author

kurlov commented Nov 10, 2025

/retest

@openshift-ci openshift-ci bot removed the lgtm label Nov 26, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 26, 2025

New changes are detected. LGTM label has been removed.

@kurlov kurlov force-pushed the akurlov/ROX-31105-fix-centralid-reading-add-log-msg branch from 34a8aeb to bff0188 Compare November 26, 2025 04:49
@kurlov kurlov changed the title ROX-31105: Fix InternalCentralIDs reading and log flag values ROX-31105: Fix InternalCentralIDs reading Nov 26, 2025
@kurlov kurlov merged commit 81ad10d into main Nov 26, 2025
14 checks passed
@kurlov kurlov deleted the akurlov/ROX-31105-fix-centralid-reading-add-log-msg branch November 26, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants