Skip to content

fix: disable all scanners in emailsender central comp test#2495

Merged
johannes94 merged 1 commit intomainfrom
jmalsam/disable-scanner-in-email-compatiblity
Nov 26, 2025
Merged

fix: disable all scanners in emailsender central comp test#2495
johannes94 merged 1 commit intomainfrom
jmalsam/disable-scanner-in-email-compatiblity

Conversation

@johannes94
Copy link
Copy Markdown
Contributor

@johannes94 johannes94 commented Nov 26, 2025

Description

https://github.com/stackrox/stackrox/pull/17932/files
In stackrox/stackrox the emailsender tests are failing because of disk space and resource issues. It makes sense to disable scanner since the test is not using scanner related features. This will reduce disk space and resource requirements of the test and hopefully make it pass.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94
Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e
/override ci/prow/images

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 26, 2025

@johannes94: Overrode contexts on behalf of johannes94: ci/prow/e2e, ci/prow/images

Details

In response to this:

/override ci/prow/e2e
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@johannes94 johannes94 merged commit ec10ef5 into main Nov 26, 2025
17 checks passed
@johannes94 johannes94 deleted the jmalsam/disable-scanner-in-email-compatiblity branch November 26, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants