Skip to content

ROX-32045: output emailsender test kube logs to artifacts#2497

Merged
johannes94 merged 6 commits intomainfrom
jmalsam/improve-logging-for-emailsender-test
Nov 27, 2025
Merged

ROX-32045: output emailsender test kube logs to artifacts#2497
johannes94 merged 6 commits intomainfrom
jmalsam/improve-logging-for-emailsender-test

Conversation

@johannes94
Copy link
Copy Markdown
Contributor

@johannes94 johannes94 commented Nov 27, 2025

Description

With previous implementation the logs and describes were unstructured and finding failures was difficult. Additionally only a small subset of logs were in the output.

With the new implementation describe and logs per pod are separated, complete and uploaded as artifacts instead of inline logs which makes debugging easier.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

CI

@johannes94 johannes94 changed the title WIP: output emailsender test kube logs to artifacts instead of console fix(ci): output emailsender test kube logs to artifacts Nov 27, 2025
@johannes94 johannes94 requested review from a team and kovayur and removed request for a team November 27, 2025 12:39
@johannes94 johannes94 changed the title fix(ci): output emailsender test kube logs to artifacts ROX-32045: output emailsender test kube logs to artifacts Nov 27, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, johannes94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 27, 2025

New changes are detected. LGTM label has been removed.

@johannes94
Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e
/override ci/prow/images

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 27, 2025

@johannes94: Overrode contexts on behalf of johannes94: ci/prow/e2e, ci/prow/images

Details

In response to this:

/override ci/prow/e2e
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@johannes94 johannes94 merged commit fd40ff6 into main Nov 27, 2025
19 checks passed
@johannes94 johannes94 deleted the jmalsam/improve-logging-for-emailsender-test branch November 27, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants