ROX-31352: Move fleetshard-sync to a dedicated chart#2515
Conversation
338046c to
2d04062
Compare
2d04062 to
7729574
Compare
7729574 to
e30c12f
Compare
| uses: stackrox/actions/infra/install-infractl@v1 | ||
| - name: Install oc | ||
| uses: redhat-actions/oc-installer@v1 | ||
| - name: Install OpenShift CLI tools |
There was a problem hiding this comment.
⚠ Note
This action has been superseded by openshift-tools-installer, which can install oc as well as other CLIs. It has support for caching across multiple workflows, and allows inputting semantic version ranges.
Makefile
Outdated
| @helm uninstall -n "$(NAMESPACE)" emailsender | ||
| @kubectl delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db" | ||
| @helm uninstall -n "$(NAMESPACE)" emailsender --ignore-not-found | ||
| @oc delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db" --ignore-not-found=true |
There was a problem hiding this comment.
Switch to oc to align with other targets
| undeploy/emailsender: | ||
| @helm uninstall -n "$(NAMESPACE)" emailsender | ||
| @kubectl delete -n "$(NAMESPACE)" -f "dev/env/manifests/emailsender-db" | ||
| @helm uninstall -n "$(NAMESPACE)" emailsender --ignore-not-found |
There was a problem hiding this comment.
Add --ignore-not-found to make the command idempotent and not fail if the chart is already uninstalled.
fb4deff to
197a428
Compare
197a428 to
b90b944
Compare
b90b944 to
c994067
Compare
c994067 to
96946a7
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
deploy/chartsdirectoryChecklist (Definition of Done)
Test manualROX-12345: ...Test manual
TODO: Add manual testing efforts