Skip to content

ci(emailsender): optimize compatibility test#2518

Merged
kovayur merged 1 commit intomainfrom
yury/optimize-emailsender-compatibility-test
Dec 19, 2025
Merged

ci(emailsender): optimize compatibility test#2518
kovayur merged 1 commit intomainfrom
yury/optimize-emailsender-compatibility-test

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Dec 18, 2025

Description

Emailsender compatibility tests fail with no disk space on a GH runner.

Test on kind cluster
System.IO.IOException: No space left on device ...

Example: https://github.com/stackrox/acs-fleet-manager/actions/runs/20276467065

Changes

  • Do not clone stackrox when running against acs-fleet-manager
  • Use roxctl from the main image instead of building it.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur force-pushed the yury/optimize-emailsender-compatibility-test branch from 4d83dab to 01a4023 Compare December 18, 2025 14:58
@kovayur kovayur force-pushed the yury/optimize-emailsender-compatibility-test branch from 01a4023 to 1500ce1 Compare December 18, 2025 15:07
@kovayur kovayur force-pushed the yury/optimize-emailsender-compatibility-test branch from 1500ce1 to 4fe19b4 Compare December 18, 2025 15:08
@kovayur kovayur force-pushed the yury/optimize-emailsender-compatibility-test branch from 4fe19b4 to fed4549 Compare December 18, 2025 15:55
@kovayur kovayur force-pushed the yury/optimize-emailsender-compatibility-test branch from fed4549 to adb04fd Compare December 18, 2025 16:00
@kovayur kovayur requested a review from johannes94 December 18, 2025 16:15
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Dec 19, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 19, 2025

New changes are detected. LGTM label has been removed.

@kovayur kovayur force-pushed the yury/optimize-emailsender-compatibility-test branch from 90d8362 to 1618362 Compare December 19, 2025 09:24
@kovayur kovayur force-pushed the yury/optimize-emailsender-compatibility-test branch from 1618362 to adb04fd Compare December 19, 2025 09:36
@kovayur kovayur merged commit f4c5c68 into main Dec 19, 2025
26 of 30 checks passed
@kovayur kovayur deleted the yury/optimize-emailsender-compatibility-test branch December 19, 2025 14:07
@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Dec 22, 2025

stackrox tested here: stackrox/stackrox#18321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants