Skip to content

fix(e2e-tests): Use jsonpath instead of condition when waiting for CRD#2521

Merged
kovayur merged 1 commit intomainfrom
yury/crd-retry
Dec 22, 2025
Merged

fix(e2e-tests): Use jsonpath instead of condition when waiting for CRD#2521
kovayur merged 1 commit intomainfrom
yury/crd-retry

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Dec 19, 2025

Description

In the dev scripts we use kubectl wait to wait until a CRD is created and initialized.
Apparently there's a race condition that sometimes leads to E2E test failures:

2025-12-18T16:23:14,777612595+00:00 Waiting for crd/addons.addons.managed.openshift.io to have status condition=established
error: .status.conditions accessor error: <nil> is of the type <nil>, expected []interface{}

Since the issue is not fixed yet, I switched to another condition type - jsonpath, that has a different behavior and probably more reliable.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur changed the title fix(e2e-tests): Use jsonpath instead of condition in the kubectl wait condtion fix(e2e-tests): Use jsonpath instead of condition when waiting for CRD Dec 19, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit cf90062 into main Dec 22, 2025
14 checks passed
@kovayur kovayur deleted the yury/crd-retry branch December 22, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants