Skip to content

fix(e2e-tests): wait for status.conditions to exist before using kubectl wait #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kovayur merged 1 commit into from
Dec 22, 2025
Merged

fix(e2e-tests): wait for status.conditions to exist before using kubectl wait #2522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions dev/env/scripts/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,35 +290,33 @@ wait_for_cluster_resource_to_appear() {
return 1
}

wait_for_crd() {
local name="$1"
local seconds="${2:-180}"

wait_for_resource_condition() {
local namespace="$1"
local kind="$2"
local name="$3"
local condition="$4"

if ! wait_for_resource_to_appear "${namespace}" "${kind}" "${name}"; then
# First wait for the CRD to appear
if ! wait_for_cluster_resource_to_appear crd "${name}"; then
return 1
fi
log "Waiting for ${kind}/${name} in namespace ${namespace} to have status ${condition}"
$KUBECTL -n "${namespace}" wait --for="${condition}" --timeout="3m" "${kind}/${name}"
}

wait_for_cluster_resource_condition() {
local kind="$1"
local name="$2"
local condition="$3"
log "Waiting for crd/${name} status.conditions to appear"
# Wait for status.conditions to exist before using kubectl wait
for _ in $(seq "$seconds"); do
local conditions
conditions=$($KUBECTL get crd "${name}" -o jsonpath='{.status.conditions}' 2>/dev/null || echo "")
if [[ -n "$conditions" && "$conditions" != "[]" ]]; then
log "crd/${name} status.conditions appeared, waiting for established condition"
break
fi
sleep 1
done

if ! wait_for_cluster_resource_to_appear "${kind}" "${name}"; then
if [[ -z "$conditions" || "$conditions" == "[]" ]]; then
log "Giving up after ${seconds}s waiting for crd/${name} status.conditions to appear"
return 1
fi
log "Waiting for ${kind}/${name} to have status ${condition}"
$KUBECTL wait --for "${condition}" --timeout="3m" "${kind}/${name}"
}

wait_for_crd() {
local name="$1"
wait_for_cluster_resource_condition crd "$name" "jsonpath={.status.conditions[?(@.type==\"Established\")].status}=True"
$KUBECTL wait --for "condition=established" --timeout="3m" "crd/${name}"
}

assemble_kubeconfig() {
Expand Down
Loading