Skip to content

ROX-32653: Bump golang to v1.25#2543

Merged
kovayur merged 2 commits intomainfrom
yury/ROX-32712-bump-go
Jan 20, 2026
Merged

ROX-32653: Bump golang to v1.25#2543
kovayur merged 2 commits intomainfrom
yury/ROX-32712-bump-go

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Jan 19, 2026

Description

ROX-32653: Bump golang to v1.25
ROX-30041: Update acs-fleet-manager base images to rhel9/ubi9
Bump golangci-lint

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 19, 2026

@github-actions[bot]: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e
/test images

Use /test all to run all jobs.

Details

In response to this:

/retest acs-emailsender-on-push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Member

@kurlov kurlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If e2e tests pass then LGTM

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Jan 19, 2026

/retest

4 similar comments
@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Jan 19, 2026

/retest

@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Jan 19, 2026

/retest

@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Jan 20, 2026

/retest

@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Jan 20, 2026

/retest

@kovayur kovayur merged commit 5f5caee into main Jan 20, 2026
17 checks passed
@kovayur kovayur deleted the yury/ROX-32712-bump-go branch January 20, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants