Skip to content

ROX-32760: Remove the addon reconciliation logic#2550

Merged
kovayur merged 1 commit intomainfrom
yury/ROX-32760-remove-addon-reconcilitation
Jan 27, 2026
Merged

ROX-32760: Remove the addon reconciliation logic#2550
kovayur merged 1 commit intomainfrom
yury/ROX-32760-remove-addon-reconcilitation

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Jan 26, 2026

Description

Remove the addon reconciliation logic, since it's being decommissioned.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

Copy link
Copy Markdown
Collaborator

@ebensh ebensh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell. Yes.

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 27, 2026

New changes are detected. LGTM label has been removed.

@kovayur kovayur force-pushed the yury/ROX-32760-remove-addon-reconcilitation branch from 6d0a84f to 5f94a06 Compare January 27, 2026 11:22
@kovayur kovayur merged commit 1e7073e into main Jan 27, 2026
24 of 35 checks passed
@kovayur kovayur deleted the yury/ROX-32760-remove-addon-reconcilitation branch January 27, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants