Skip to content

fix: workaround for emailsender kind image load#2577

Merged
johannes94 merged 6 commits intomainfrom
jmalsam/fix-emailsender-image-load
Feb 18, 2026
Merged

fix: workaround for emailsender kind image load#2577
johannes94 merged 6 commits intomainfrom
jmalsam/fix-emailsender-image-load

Conversation

@johannes94
Copy link
Copy Markdown
Contributor

@johannes94 johannes94 commented Feb 18, 2026

Description

With the docker update in GitHub the emailsender compatiblity tests was broken on loading the image to kind.

@davdhacs tried to fix that for the stackrox/stackrox copy of this workflow with stackrox/stackrox#19050

I tried one of the workarounds from the comment section of that related issue in the kind repo suggested by @porridge. kubernetes-sigs/kind#3795 (comment)

It looks like that fixes the test.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

@johannes94 johannes94 force-pushed the jmalsam/fix-emailsender-image-load branch from 2bc0eb3 to ef26bf8 Compare February 18, 2026 08:55
@johannes94
Copy link
Copy Markdown
Contributor Author

Maybe it's already all running in a temporary directory, but in case it's not, you might want to put the tarf files there rather than current directory, whatever it is.

It's not, I changed the script to use a mktemp -d

done

kind load docker-image "${img}"
docker save --platform amd64 "$img" -o "$IMG_TAR_DIR/$imgname.tar"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 great!

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davdhacs, johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94
Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e

Not relevant to this change.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 18, 2026

@johannes94: Overrode contexts on behalf of johannes94: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e

Not relevant to this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@johannes94 johannes94 merged commit 4a7b3b6 into main Feb 18, 2026
30 of 35 checks passed
@johannes94 johannes94 deleted the jmalsam/fix-emailsender-image-load branch February 18, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants