Skip to content

ROX-33400: vendor ArgoCD v1alpha1.Application#2605

Merged
kovayur merged 1 commit intomainfrom
yury/argocd-vendor
Mar 2, 2026
Merged

ROX-33400: vendor ArgoCD v1alpha1.Application#2605
kovayur merged 1 commit intomainfrom
yury/argocd-vendor

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Feb 26, 2026

Description

Currently, to use ArgoCD types, we import the entire ArgoCD dependency, which brings many transitive dependencies into our project. This can lead to dependency update issues (see #2592, #2578) and may require us to use specific compatible versions of other dependencies (e.g. k8s client libs) and our Go runtime. This PR addresses this by "vendoring" the v1alpha1.Application type from ArgoCD. This is a temporary measure until these types are moved to a separate, thin module.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@github-actions
Copy link
Copy Markdown

/konflux-retest acs-emailsender-on-push

@kovayur kovayur changed the title chore: vendor ArgoCD v1alpha1.Application ROX-33400: vendor ArgoCD v1alpha1.Application Feb 27, 2026
@kovayur kovayur requested review from johannes94 and kurlov March 2, 2026 10:19
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [johannes94,kovayur,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit ccf1708 into main Mar 2, 2026
21 of 22 checks passed
@kovayur kovayur deleted the yury/argocd-vendor branch March 2, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants