Skip to content

fix(fleet-manager): Add missing client origin#2655

Merged
kovayur merged 1 commit intomainfrom
yury/add-missing-client-origin
Apr 2, 2026
Merged

fix(fleet-manager): Add missing client origin#2655
kovayur merged 1 commit intomainfrom
yury/add-missing-client-origin

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Apr 2, 2026

Description

There's a regression after #2645. I forgot to augment the dynamic config with a proper client origin. This leads to skipping the dynamic client deletion during deprovisioning.

I0401 15:58:34.204341       1 deleting_centrals_mgr.go:141] invalid client origin  found for central d76jgrpldp8s73dtvs00. No deletion will be attempted

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur requested a review from kurlov April 2, 2026 09:29
@openshift-ci openshift-ci bot added the approved label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Apr 2, 2026

/override ci/prow/e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@kovayur: Overrode contexts on behalf of kovayur: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kovayur kovayur merged commit db3d572 into main Apr 2, 2026
12 checks passed
@kovayur kovayur deleted the yury/add-missing-client-origin branch April 2, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants