-
Notifications
You must be signed in to change notification settings - Fork 30
ROX-33886 Add CodeRabbit config for collector repo #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robbycochran
wants to merge
4
commits into
master
Choose a base branch
from
rc-add-coderabbit-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
|
|
||
| # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json | ||
| inheritance: true | ||
|
|
||
| reviews: | ||
| profile: assertive | ||
| high_level_summary: true | ||
| auto_review: | ||
| enabled: true | ||
| drafts: false | ||
| base_branches: | ||
| - master | ||
| - main | ||
| - "release-.*" | ||
|
|
||
| path_instructions: | ||
| - path: "**/*.{cpp,cc,cxx}" | ||
| instructions: > | ||
| C++ systems code. Review for memory safety, RAII compliance, proper | ||
| error handling, and thread safety. This code runs in a privileged | ||
| container and interacts with eBPF probes, so pay attention to | ||
| security, resource cleanup, and signal handling. Prefer modern C++ | ||
| idioms (smart pointers, std::string_view, structured bindings). | ||
| Flag any raw new/delete. | ||
robbycochran marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - path: "**/*.c" | ||
| instructions: > | ||
| eBPF C code. Review for verifier constraints (bounded loops, | ||
| stack/memory safety, helper-call correctness), and stable ABI | ||
| contracts with userspace (map key/value layout compatibility). | ||
| - path: "**/*.{h,hpp}" | ||
| instructions: > | ||
| C++ headers. Check include guards, minimal includes, and clean | ||
| public interfaces. Ensure no implementation details leak into | ||
| headers unnecessarily. | ||
| - path: "**/*.proto" | ||
| instructions: > | ||
| Protobuf definitions. Verify backward compatibility of field | ||
| changes (no renumbering, no removing fields in use). Check that | ||
| field types and names follow protobuf style conventions. | ||
| - path: "**/*.go" | ||
| instructions: > | ||
| Go integration tests that exercise the agent against real container | ||
| runtimes and kernel configurations. Review for test reliability | ||
| (no flaky assertions, proper timeouts, cleanup of test resources), | ||
| clear failure messages, and correct use of the testing package. | ||
| Tests run in CI VMs, so be mindful of environment assumptions. | ||
robbycochran marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - path: "**/*.{yml,yaml}" | ||
| instructions: > | ||
| YAML files may be Ansible playbooks, CI workflows, or configuration. | ||
| For Ansible: review for idempotency, proper use of handlers and | ||
| variables, secure credential handling (no hardcoded secrets), and | ||
| correct task naming with appropriate error handling (block/rescue). | ||
| For GitHub Actions: pin action versions to SHA, minimize token | ||
| permissions, avoid script injection via untrusted inputs, and | ||
| verify caching efficiency. | ||
| - path: "**/*.sh" | ||
| instructions: > | ||
| Shell scripts used in build and CI. Review for POSIX compliance | ||
| where appropriate, proper quoting of variables, set -euo pipefail | ||
| usage, and safe handling of paths with spaces. Check for proper | ||
| exit code propagation. | ||
| - path: "**/CMakeLists.txt" | ||
| instructions: > | ||
| CMake build configuration. Check for correct target dependencies, | ||
| proper use of PUBLIC/PRIVATE/INTERFACE keywords, and that compile | ||
| options are appropriate for the target platform. | ||
| - path: "**/{Dockerfile,Dockerfile.*,*.Dockerfile}" | ||
| instructions: > | ||
| Container image definitions. Review for minimal base images, | ||
| proper layer ordering for cache efficiency, no secrets in build | ||
| args, and that the final image has minimal attack surface. | ||
| - path: "**/Makefile*" | ||
| instructions: > | ||
| Build system Makefiles. Check for correct dependency declarations, | ||
| proper use of variables, and that phony targets are declared. | ||
|
|
||
| tools: | ||
| cppcheck: | ||
| enabled: true | ||
| shellcheck: | ||
| enabled: true | ||
| yamllint: | ||
| enabled: true | ||
| golangci-lint: | ||
| enabled: true | ||
| hadolint: | ||
| enabled: true | ||
| semgrep: | ||
| enabled: true | ||
| gitleaks: | ||
| enabled: true | ||
|
|
||
| chat: | ||
| auto_reply: true | ||
|
|
||
| knowledge_base: | ||
| code_guidelines: | ||
| enabled: true | ||
| learnings: | ||
| scope: auto | ||
| issues: | ||
| scope: auto | ||
| pull_requests: | ||
| scope: auto | ||
| web_search: | ||
| enabled: true | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the leading blank line to fix YAMLlint failure.
Line 1 triggers the reported
empty-lineslint error and will keep the config non-clean in CI.Diff suggestion
- # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json inheritance: true📝 Committable suggestion
🧰 Tools
🪛 YAMLlint (1.38.0)
[error] 1-1: too many blank lines (1 > 0)
(empty-lines)
🤖 Prompt for AI Agents