Conversation
janisz
force-pushed
the
reuse_jar
branch
2 times, most recently
from
0931489 to
e2c58f2
Compare
janisz
commented
Mar 29, 2023
|
You have successfully added a new CodeQL configuration |
This was referenced Mar 29, 2023
Merged
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Mar 29, 2023
janisz
force-pushed
the
remove_custom_proxy
branch
from
efabb0c to
5b7336c
Compare
dhaus67
approved these changes
Mar 29, 2023
Contributor
Author
Contributor
Author
|
Graphite failed to merge this pull request for an unknown reason. Try your merge again, or report a bug if you see this consistently. |
Contributor
Author
Contributor
Author
|
Graphite rebased this pull request as part of a merge. |
Contributor
Author
|
Graphite failed to merge this pull request for an unknown reason. Try your merge again, or report a bug if you see this consistently. |
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we generate API client in jenkins-plugin and upload
jarto repository there is no need to regenerate client in e2e tests. We can reuse previously generated client. This will save build time, reduce number of dependencies and reuse plugin code giving us more coverage.