Skip to content

ROX-16728: On validation show concrete error#259

Merged
janisz merged 5 commits intomasterfrom
ROX-16728_print_info_about_error
Jul 26, 2023
Merged

ROX-16728: On validation show concrete error#259
janisz merged 5 commits intomasterfrom
ROX-16728_print_info_about_error

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Jun 21, 2023

When user wan to validate configuration currently they will get generic message and stack trace in details.
This PR

  • alters the message based on root cause.

  • fixes page crash (unhandled exception) when user input invalid URL

  • wrong answer from central (maybe it's not central at all or token is wrong)
    404

  • port is not listening
    Screenshot 2023-06-21 at 16-54-07 Konfiguracja sdffsd Jenkins

  • wrong certificate
    tls

  • unknown host
    unknownhost

@janisz janisz requested a review from rukletsov June 21, 2023 16:24
@janisz janisz requested a review from dhaus67 June 21, 2023 16:30
Copy link
Copy Markdown
Member

@rukletsov rukletsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I left a few minor comments. Also not sure you want to follow the seemingly established pattern here where error messages are defined in Messages.properties?

Copy link
Copy Markdown

@dhaus67 dhaus67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module the existing comments left.

janisz and others added 3 commits July 24, 2023 15:23
…nkins/plugins/StackroxBuilder.java

Co-authored-by: Alex Rukletsov <rukletsov@gmail.com>
…nkins/plugins/StackroxBuilder.java

Co-authored-by: Alex Rukletsov <rukletsov@gmail.com>
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Jul 24, 2023

Looks good, thanks. I left a few minor comments. Also not sure you want to follow the seemingly established pattern here where error messages are defined in Messages.properties?

@rukletsov I think we should remove Messages.properties. It's useful if we would like to translate the plugin but we never have such request so we move some strings to properties adding another moving element that we need to maintain (properties are handled by a generated helper).

@janisz janisz requested review from dhaus67 and rukletsov July 24, 2023 13:52
@janisz janisz merged commit 591e05e into master Jul 26, 2023
@janisz janisz deleted the ROX-16728_print_info_about_error branch July 26, 2023 11:29
@dhaus67 dhaus67 added the bug Something isn't working label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants