ROX-16728: On validation show concrete error#259
Merged
Conversation
rukletsov
approved these changes
Jun 21, 2023
Member
rukletsov
left a comment
There was a problem hiding this comment.
Looks good, thanks. I left a few minor comments. Also not sure you want to follow the seemingly established pattern here where error messages are defined in Messages.properties?
…nkins/plugins/StackroxBuilder.java Co-authored-by: Alex Rukletsov <rukletsov@gmail.com>
…nkins/plugins/StackroxBuilder.java Co-authored-by: Alex Rukletsov <rukletsov@gmail.com>
Contributor
Author
@rukletsov I think we should remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When user wan to validate configuration currently they will get generic message and stack trace in details.
This PR
alters the message based on root cause.
fixes page crash (unhandled exception) when user input invalid URL
wrong answer from central (maybe it's not central at all or token is wrong)

port is not listening

wrong certificate

unknown host
