Skip to content

fix: set user agent#402

Merged
janisz merged 4 commits intomasterfrom
set_user_agent
Jan 31, 2025
Merged

fix: set user agent#402
janisz merged 4 commits intomasterfrom
set_user_agent

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Jan 30, 2025

Description

This PR adds a custom UserAgent for request made by plugin. The format is

<plugin-name>/<plugin-version>:<jenkins-version> (<os>; <arch>) CI

Example:

stackrox-container-image-scanner/1.4.1-SNAPSHOT_(private-a8df60e6-janisz):2.164.1 (Linux; amd64) CI

Refs:
https://github.com/stackrox/stackrox/blob/ff73e395a8b08bedd64ecf42d4cc0ccaa2de2673/pkg/clientconn/useragent.go#L28-L38

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested a review from rhybrillou as a code owner January 30, 2025 15:31
@janisz janisz requested a review from a team January 30, 2025 16:05
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested a review from rukletsov January 31, 2025 12:07
Copy link
Copy Markdown
Member

@rukletsov rukletsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, Tomek!

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested a review from parametalol January 31, 2025 15:36
Copy link
Copy Markdown

@parametalol parametalol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janisz janisz merged commit 7ce4e80 into master Jan 31, 2025
@janisz janisz deleted the set_user_agent branch January 31, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants