Merged
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
rhybrillou
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We previously hardcoded the paths to webjars, including their versions. When Dependabot updated dependencies, these hardcoded paths were not updated, leading to missing JS and CSS files.
To prevent this issue, this PR moves the versioning to a property, ensuring paths are dynamically updated. Since webjar changes affect the UI and we do not have visual regression tests in place, this PR also excludes webjars from Dependabot updates. Additionally, as there might be breaking changes in JS/CSS, this PR reverts the recent webjar upgrades.
This PR reverts changes from:
Fixes: