Conversation
RTann
reviewed
Jul 26, 2024
|
This seems unrelated to the other PR you have. I think this should just be based on the master/main branch and may be merged before that other PR |
3795271 to
54090bf
Compare
RTann
reviewed
Jul 26, 2024
Co-authored-by: Ross Tannenbaum <rtannenb@redhat.com>
54090bf to
dd33f9d
Compare
RTann
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps to a more recent version of
go, one patch release higher than the version declared in stackrox/stackrox.Testing:
Test the output of
make ossls-noticeon stackrox before and after the change:Manual inspection of both manifest.csv files shows a slight change in the ordering, but otherwise contents is the same. The updated ossls seems to handle version numbers in ascending order now, e.g. with
difft: