Skip to content

fix: analyze rhel* nodes #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davdhacs wants to merge 3 commits into from
Closed

fix: analyze rhel* nodes #1918

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c597732
analyze non-rhcos nodes
davdhacs Jun 4, 2025
cc81f16
allow node scan on rhel prefixes
davdhacs Jun 5, 2025
a0c4215
Revert "analyze non-rhcos nodes"
davdhacs Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/analyzer/detection/detection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ type DetectComponentOpts struct {
// if CoreOS is required for DetectComponents, the namespace must start with `rhcos`
func DetectComponents(name string, files analyzer.Files, parent *database.Layer, languageComponents []*component.Component, opts DetectComponentOpts) (*database.Namespace, []database.FeatureVersion, *database.RHELv2Components, []*component.Component, error) {
namespace := DetectNamespace(name, files, parent, opts.UncertifiedRHEL)
if namespace != nil && opts.IsRHCOSRequired && !wellknownnamespaces.IsRHCOSNamespace(namespace.Name) {
if namespace != nil && opts.IsRHCOSRequired && !wellknownnamespaces.IsRHCOSNamespace(namespace.Name) && !wellknownnamespaces.IsRHELNamespace(namespace.Name) {
logrus.WithFields(logrus.Fields{LogLayerName: name, "detected namespace": namespace.Name}).Warning("Unable to start node scanning for this namespace")
return namespace, nil, nil, nil, ErrNodeScanningUnavailable
}
Expand Down