Skip to content

Normalize usernames to lowercase to prevent cache fragmentation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Normalize usernames to lowercase to prevent cache fragmentation #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ function parseChartParams(url: URL) {

const usernames = usersParam
.split(",")
.map((u) => u.trim())
.map((u) => u.trim().toLowerCase())
.filter(Boolean)
.slice(0, MAX_USERS);

if (usernames.length === 0) return { error: "No usernames provided" };

return { usernames, range: rangeParam as TimeRange, selfUser, theme };
return { usernames, range: rangeParam as TimeRange, selfUser: selfUser.toLowerCase(), theme };
}

/** Generate SVG string for given params (shared by /api/svg and /api/png). */
Expand Down Expand Up @@ -204,7 +204,7 @@ async function handleApi(

const usernames = usersParam
.split(",")
.map((u) => u.trim())
.map((u) => u.trim().toLowerCase())
.filter(Boolean)
.slice(0, MAX_USERS);

Expand Down Expand Up @@ -238,7 +238,7 @@ async function handlePageWithOgTags(
const url = new URL(request.url);

// Parse user params from either new or legacy format
const selfUser = url.searchParams.get("user") || "";
const selfUser = (url.searchParams.get("user") || "").toLowerCase();
const targetsParam = url.searchParams.get("targets") || "";
const usersParam = url.searchParams.get("users") || "";
const range = url.searchParams.get("range") || "3m";
Expand All @@ -247,10 +247,10 @@ async function handlePageWithOgTags(
let targets: string[];

if (targetsParam) {
targets = targetsParam.split(",").map(u => u.trim()).filter(Boolean);
targets = targetsParam.split(",").map(u => u.trim().toLowerCase()).filter(Boolean);
allUsers = [selfUser, ...targets].filter(Boolean);
} else if (usersParam) {
allUsers = usersParam.split(",").map(u => u.trim()).filter(Boolean);
allUsers = usersParam.split(",").map(u => u.trim().toLowerCase()).filter(Boolean);
targets = selfUser ? allUsers.filter(u => u !== selfUser) : allUsers;
} else {
// No chart params — serve static page as-is
Expand Down